Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Normalize inline spacing of image and file button on ThreadView #8664

Merged
merged 4 commits into from
May 21, 2022
Merged

Normalize inline spacing of image and file button on ThreadView #8664

merged 4 commits into from
May 21, 2022

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 21, 2022

This PR replaces padding of an image and a file button on group layout on ThreadView with margin.

Purple: padding
Yellow: margin

Before After
before after

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

type: task


This change is marked as an internal change (Task), so will not be included in the changelog.

luixxiul added 4 commits May 22, 2022 03:01
…layout on ThreadView

This normalizes inline spacing of image and file button on ThreadView.

The declarations of EventTile_mediaLine was added with 3a2aa9d, and they were expected to align the element with mx_EventTile_content. After the padding-right value for mx_EventTile_content was changed from 50px to 8px with 544957b, the declarations have been obsolete.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
As padding properties for mx_EventTile_mediaLine were removed, !important flag is no longer required.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 21, 2022
@luixxiul luixxiul marked this pull request as ready for review May 21, 2022 18:25
@luixxiul luixxiul requested a review from a team as a code owner May 21, 2022 18:25
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SimonBrandner SimonBrandner merged commit 23babbb into matrix-org:develop May 21, 2022
@luixxiul
Copy link
Contributor Author

This change broke placement of audio player in a thread. I'm pushing a more generalized fix to prevent a similar bug from happening.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants