This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Improve style rules for thread summary #8868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-Community-PR
luixxiul
changed the title
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
mixin ThreadSummaryIcon has "background-color: $secondary-content !important" Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
….scss Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…readSummary Expected according to tests Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
luixxiul
commented
Jun 27, 2022
| } | ||
|
|
||
| .mx_ThreadSummary_avatar { | ||
| margin-inline-end: $spacing-8; | ||
| } | ||
|
|
||
| .mx_ThreadSummary_icon { |
There was a problem hiding this comment.
ThreadSummary and ThreadSummary_icon is used differently, therefore the latter cannot be wrapped with the former.
turt2live
approved these changes
Jun 29, 2022
|
@luixxiul this appears to have conflicts which github can't autofix :( |
luixxiul
commented
Jul 1, 2022
res/css/views/rooms/_EventTile.scss
Outdated
| @@ -18,7 +18,11 @@ limitations under the License. | |||
| $left-gutter: 64px; | |||
|
|
|||
| .mx_EventTile { | |||
| --EventTile-gutter-start: $left-gutter; | |||
There was a problem hiding this comment.
This was removed in favor of --EventTile_group_line-spacing-inline-start.
|
merging - SonarCloud is wrong about there being a bug in this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves style rules for the thread summary on timeline and thread panel from
_EventTile.scssto_ThreadSummary.scss, merging the rules and adjusting them with variables, etc.Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
type: task
This change is marked as an internal change (Task), so will not be included in the changelog.