This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Handle ORG.MATRIX.MSC3848.ALREADY_JOINED, INSUFFICIENT_POWER when inviting users #9085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DY_JOINED errors for invites
Half-Shot
changed the title
andybalaam
approved these changes
Jul 21, 2022
| errorText = _t('You do not have permission to invite people to this room.'); | ||
| } | ||
| fatal = true; | ||
| for (const errcode of [err.unstableErrcode, err.errcode]) { |
There was a problem hiding this comment.
Any chance we can have some unit tests of this functionality? Or is it already covered (I couldn't find anything)
There was a problem hiding this comment.
It's not tested, but I'd be fine with doing so if I can figure it out :)
There was a problem hiding this comment.
Brilliant, thank you. #element-dev might have suggestions if it proves tricky.
andybalaam
added
the
T-Enhancement
|
Closing as matrix-org/matrix-js-sdk#2534 was abandoned |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/matrix-js-sdk#2534
This is just a minimal implementation of MSC3848. It's a bit superficial in that we're not really showing more detailed messages here (because the messages already contain the right amount of detail) and in some cases these errors won't be triggered because the client will do state checks before calling the API.
Here's what your changelog entry will look like:
✨ Features