This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Convert inputs on Export/Import Room Key dialogs to be real Fields #9350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added
the
T-Task
duxovni
approved these changes
Oct 4, 2022
|
bypassing quality gate because the code being changed here isn't meaningful. The dialog should probably be tested, though. Have opened element-hq/element-web#23422 to track the general lack of tests in this area. also bypassing cypress because it's flat-out wrong. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#18517
Excluding the file upload because that appears to require Decisions™ from design. This dialog needs more significant work anyhow, so will leave the file upload to that point in time.
This change is marked as an internal change (Task), so will not be included in the changelog.