Room call banner #9378

toger5 · 2022-10-09T14:51:41Z

Closes element-hq/element-web#23453

Checklist

Tests written for new code (and old code if feasible)
Linter and other CI checks pass
Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

Room call banner (#9378). Fixes Implement the new group call designs (Element Call) 2/2 element-hq/element-web#23453. Contributed by @toger5.

src/components/views/beacon/RoomCallBanner.tsx

Signed-off-by: Timo K <timok@element.io>

robintown

It'd be nice to see a screenshot of what this looks like :)

test/components/views/beacon/RoomCallBanner-test.tsx

src/components/views/beacon/RoomCallBanner.tsx

res/css/views/rooms/_RoomCallBanner.pcss

test/components/views/beacon/RoomCallBanner-test.tsx

test/test-utils/call.ts

src/components/views/beacon/RoomCallBanner.tsx

Co-authored-by: Robin <robin@robin.town>

turt2live

looks like this has been reviewed by other people already - no additional comments to add on my side

SimonBrandner

Otherwise LGTM

src/components/views/beacon/RoomCallBanner.tsx

test/components/views/beacon/RoomCallBanner-test.tsx

src/components/views/beacon/RoomCallBanner.tsx

dbkr · 2022-10-17T19:20:22Z

src/components/views/beacon/RoomCallBanner.tsx

+const RoomCallBanner: React.FC<Props> = ({ roomId }) => {
+    const call = useCall(roomId);
+
+    // this section is to check if we have a live location share. If so, we dont show the call banner


If the comment could mention why, it could be helpful - I'm assuming because they just occupy the same space, in which case this i obviously a bit nonideal & we probably want something a bit more like the toast manager that decides which one takes precedence (but no need to block on that part).

yes, carry also proposed a better solution than what it currently is. (this makes testing easier though (I think) since it is all inside one component)

@toger5

* Include a file-safe room name and ISO date in chat exports ([\matrix-org#9440](matrix-org#9440)). Fixes element-hq/element-web#21812 and element-hq/element-web#19724. * Room call banner ([\matrix-org#9378](matrix-org#9378)). Fixes element-hq/element-web#23453. Contributed by @toger5. * Device manager - spinners while devices are signing out ([\matrix-org#9433](matrix-org#9433)). Fixes element-hq/element-web#15865. * Device manager - silence call ringers when local notifications are silenced ([\matrix-org#9420](matrix-org#9420)). * Pass the current language to Element Call ([\matrix-org#9427](matrix-org#9427)). * Hide screen-sharing button in Element Call on desktop ([\matrix-org#9423](matrix-org#9423)). * Add reply support to WysiwygComposer ([\matrix-org#9422](matrix-org#9422)). Contributed by @florianduros. * Disconnect other connected devices (of the same user) when joining an Element call ([\matrix-org#9379](matrix-org#9379)). * Device manager - device tile main click target ([\matrix-org#9409](matrix-org#9409)). * Add formatting buttons to the rich text editor ([\matrix-org#9410](matrix-org#9410)). Contributed by @florianduros. * Device manager - current session context menu ([\matrix-org#9386](matrix-org#9386)). * Remove piwik config fallback for privacy policy URL ([\matrix-org#9390](matrix-org#9390)). * Add the first step to integrate the matrix wysiwyg composer ([\matrix-org#9374](matrix-org#9374)). Contributed by @florianduros. * Device manager - UA parsing tweaks ([\matrix-org#9382](matrix-org#9382)). * Device manager - remove client information events when disabling setting ([\matrix-org#9384](matrix-org#9384)). * Add Element Call participant limit ([\matrix-org#9358](matrix-org#9358)). * Add Element Call room settings ([\matrix-org#9347](matrix-org#9347)). * Device manager - render extended device information ([\matrix-org#9360](matrix-org#9360)). * New group call experience: Room header and PiP designs ([\matrix-org#9351](matrix-org#9351)). * Pass language to Jitsi Widget ([\matrix-org#9346](matrix-org#9346)). Contributed by @Fox32. * Add notifications and toasts for Element Call calls ([\matrix-org#9337](matrix-org#9337)). * Device manager - device type icon ([\matrix-org#9355](matrix-org#9355)). * Delete the remainder of groups ([\matrix-org#9357](matrix-org#9357)). Fixes element-hq/element-web#22770. * Device manager - display client information in device details ([\matrix-org#9315](matrix-org#9315)). * Send Content-Type: application/json header for integration manager /register API ([\matrix-org#9490](matrix-org#9490)). Fixes element-hq/element-web#23580. * Device manager - put client/browser device metadata in correct section ([\matrix-org#9447](matrix-org#9447)). * update the room unread notification counter when the server changes the value without any related read receipt ([\matrix-org#9438](matrix-org#9438)). * Don't show call banners in video rooms ([\matrix-org#9441](matrix-org#9441)). * Prevent useContextMenu isOpen from being true if the button ref goes away ([\matrix-org#9418](matrix-org#9418)). Fixes matrix-org/element-web-rageshakes#15637. * Automatically focus the WYSIWYG composer when you enter a room ([\matrix-org#9412](matrix-org#9412)). * Improve the tooltips on the call lobby join button ([\matrix-org#9428](matrix-org#9428)). * Pass the homeserver's base URL to Element Call ([\matrix-org#9429](matrix-org#9429)). Fixes element-hq/element-web#23301. * Better accommodate long room names in call toasts ([\matrix-org#9426](matrix-org#9426)). * Hide virtual widgets from the room info panel ([\matrix-org#9424](matrix-org#9424)). Fixes element-hq/element-web#23494. * Inhibit clicking on sender avatar in threads list ([\matrix-org#9417](matrix-org#9417)). Fixes element-hq/element-web#23482. * Correct the dir parameter of MSC3715 ([\matrix-org#9391](matrix-org#9391)). Contributed by @dhenneke. * Use a more correct subset of users in `/remakeolm` developer command ([\matrix-org#9402](matrix-org#9402)). * use correct default for notification silencing ([\matrix-org#9388](matrix-org#9388)). Fixes element-hq/element-web#23456. * Device manager - eagerly create `m.local_notification_settings` events ([\matrix-org#9353](matrix-org#9353)). * Close incoming Element call toast when viewing the call lobby ([\matrix-org#9375](matrix-org#9375)). * Always allow enabling sending read receipts ([\matrix-org#9367](matrix-org#9367)). Fixes element-hq/element-web#23433. * Fixes (element-hq/element-web/issues/22609) where the white theme is not applied when `white -> dark -> white` sequence is done. ([\matrix-org#9320](matrix-org#9320)). Contributed by @florianduros. * Fix applying programmatically set height for "top" room layout ([\matrix-org#9339](matrix-org#9339)). Contributed by @Fox32.

SimonBrandner mentioned this pull request Oct 9, 2022

Implement the new group call designs (Element Call) 1/2 element-hq/element-web#23107

Closed

9 tasks

fkwp mentioned this pull request Oct 10, 2022

Implement the new group call designs (Element Call) 2/2 element-hq/element-web#23453

Closed

2 tasks

fkwp added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements T-Task Refactoring, enabling or disabling functionality, other engineering tasks T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Oct 12, 2022

github-actions bot deployed to Netlify October 17, 2022 09:15 View deployment

github-actions bot deployed to Netlify October 17, 2022 09:21 View deployment

github-actions bot deployed to Netlify October 17, 2022 09:28 View deployment

github-actions bot deployed to Netlify October 17, 2022 09:59 View deployment

toger5 marked this pull request as ready for review October 17, 2022 10:57

toger5 requested a review from a team as a code owner October 17, 2022 10:57

toger5 requested review from t3chguy, kerryarchibald and robintown October 17, 2022 10:57

github-actions bot deployed to Netlify October 17, 2022 11:01 View deployment

toger5 commented Oct 17, 2022

View reviewed changes

src/components/views/beacon/RoomCallBanner.tsx Outdated Show resolved Hide resolved

github-actions bot deployed to Netlify October 17, 2022 11:36 View deployment

toger5 added 9 commits October 17, 2022 13:47

Room call banner

194cdec

test

29f48ed

more tests

afaee18

Signed-off-by: Timo K <timok@element.io>

spacing

af4417f

Signed-off-by: Timo K <timok@element.io>

fix alignment

13349c1

Signed-off-by: Timo K <timok@element.io>

fiox alignment

3f3f35e

Signed-off-by: Timo K <timok@element.io>

lint and test cleanup

fa5ccde

Signed-off-by: Timo K <timok@element.io>

remove unused import

b2f53cb

Signed-off-by: Timo K <timok@element.io>

more tests

3a81bfe

Signed-off-by: Timo K <timok@element.io>

toger5 force-pushed the toger5/call_banner branch from 95442c9 to 3a81bfe Compare October 17, 2022 11:48

github-actions bot deployed to Netlify October 17, 2022 11:55 View deployment

robintown reviewed Oct 17, 2022

View reviewed changes

dbkr reviewed Oct 17, 2022

View reviewed changes

src/components/views/beacon/RoomCallBanner.tsx Outdated Show resolved Hide resolved

toger5 and others added 3 commits October 17, 2022 18:45

Update src/components/views/beacon/RoomCallBanner.tsx

fecd428

Co-authored-by: Robin <robin@robin.town>

Update test/components/views/beacon/RoomCallBanner-test.tsx

11ed620

Co-authored-by: Robin <robin@robin.town>

Update test/components/views/beacon/RoomCallBanner-test.tsx

f792d01

Co-authored-by: Robin <robin@robin.town>

turt2live reviewed Oct 17, 2022

View reviewed changes

github-actions bot deployed to Netlify October 17, 2022 17:06 View deployment

toger5 requested review from robintown, kerryarchibald and t3chguy October 17, 2022 17:32

reviews

211c9bc

github-actions bot deployed to Netlify October 17, 2022 17:39 View deployment

style pcss

8e8d02d

github-actions bot deployed to Netlify October 17, 2022 17:49 View deployment

stylelint

01b708e

github-actions bot deployed to Netlify October 17, 2022 17:54 View deployment

remove leave button from header

7a94db3

github-actions bot deployed to Netlify October 17, 2022 18:04 View deployment

...

bebe0ff

github-actions bot deployed to Netlify October 17, 2022 18:09 View deployment

SimonBrandner approved these changes Oct 17, 2022

View reviewed changes

src/components/views/beacon/RoomCallBanner.tsx Outdated Show resolved Hide resolved

src/components/views/beacon/RoomCallBanner.tsx Outdated Show resolved Hide resolved

test/components/views/beacon/RoomCallBanner-test.tsx Show resolved Hide resolved

toger5 added 3 commits October 17, 2022 20:32

review

8df7762

Merge branch 'develop' into toger5/call_banner

6d84327

imports...

9741353

github-actions bot deployed to Netlify October 17, 2022 18:39 View deployment

robintown approved these changes Oct 17, 2022

View reviewed changes

src/components/views/beacon/RoomCallBanner.tsx Outdated Show resolved Hide resolved

src/components/views/beacon/RoomCallBanner.tsx Outdated Show resolved Hide resolved

review + more tests

55146e7

github-actions bot deployed to Netlify October 17, 2022 19:18 View deployment

dbkr reviewed Oct 17, 2022

View reviewed changes

toger5 merged commit 372720e into develop Oct 17, 2022

toger5 deleted the toger5/call_banner branch October 17, 2022 19:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Room call banner #9378

Room call banner #9378

toger5 commented Oct 9, 2022 •

edited by github-actions bot

Loading

robintown left a comment

turt2live left a comment

SimonBrandner left a comment

dbkr Oct 17, 2022

toger5 Oct 17, 2022

Room call banner #9378

Room call banner #9378

Conversation

toger5 commented Oct 9, 2022 • edited by github-actions bot Loading

Checklist

✨ Features

robintown left a comment

Choose a reason for hiding this comment

turt2live left a comment

Choose a reason for hiding this comment

SimonBrandner left a comment

Choose a reason for hiding this comment

dbkr Oct 17, 2022

Choose a reason for hiding this comment

toger5 Oct 17, 2022

Choose a reason for hiding this comment

toger5 commented Oct 9, 2022 •

edited by github-actions bot

Loading