This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
don't focus_composer on window focus #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but with this at least clicking on a text input will not make you be thrown into composer instead Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
… t3chguy/fix-focus-steal
|
Can one of the admins verify this patch? |
|
yeah, i didn't even realise we autofocused the composer on window focus. Surely the browser will remember your focus on the page from before you switched away, which is normally going to be the composer anyway? I'm not sure what the autofocus buys us at all... |
|
@ara4n you happy for me to just rip out the Window onFocus thing then? |
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
changed the title
|
lgtm ,thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at the very least this means that if you click off the browser then onto a text input in riot it won't send you to composer instead. Though returning to the window clicking on a Modal (for e.g, not its input) would send focus to composer anyway so maybe scrapping the whole window onFocus would be the right thing to do?
for element-hq/element-web#1730