Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Tweak voice broadcast play icon #9622

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Tweak voice broadcast play icon #9622

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fca133b
Tweak voice broadcast play icon
weeman1337 Nov 25, 2022
97ee842
Trigger CI
weeman1337 Nov 28, 2022
571eccc
Trigger CI
weeman1337 Nov 28, 2022
6909ace
Merge branch 'develop' into weeman1337/tweak-voice-broadcast-play-icon
weeman1337 Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions res/css/voice-broadcast/atoms/_VoiceBroadcastControl.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,8 @@ limitations under the License.
.mx_VoiceBroadcastControl-recording {
color: $alert;
}

.mx_VoiceBroadcastControl-play .mx_Icon {
left: 1px;
position: relative;
}
4 changes: 4 additions & 0 deletions src/voice-broadcast/components/molecules/VoiceBroadcastPlaybackBody.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,17 @@ export const VoiceBroadcastPlaybackBody: React.FC<VoiceBroadcastPlaybackBodyProp
} else {
let controlIcon: React.FC<React.SVGProps<SVGSVGElement>>;
let controlLabel: string;
let className = "";

switch (playbackState) {
case VoiceBroadcastPlaybackState.Stopped:
controlIcon = PlayIcon;
className = "mx_VoiceBroadcastControl-play";
controlLabel = _t("play voice broadcast");
break;
case VoiceBroadcastPlaybackState.Paused:
controlIcon = PlayIcon;
className = "mx_VoiceBroadcastControl-play";
controlLabel = _t("resume voice broadcast");
break;
case VoiceBroadcastPlaybackState.Playing:
Expand All @@ -79,6 +82,7 @@ export const VoiceBroadcastPlaybackBody: React.FC<VoiceBroadcastPlaybackBodyProp
}

control = <VoiceBroadcastControl
className={className}
label={controlLabel}
icon={controlIcon}
onClick={toggle}
Expand Down
4 changes: 2 additions & 2 deletions ...ice-broadcast/components/molecules/__snapshots__/VoiceBroadcastPlaybackBody-test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ exports[`VoiceBroadcastPlaybackBody when rendering a 0/not-live broadcast should
</div>
<div
aria-label="resume voice broadcast"
class="mx_AccessibleButton mx_VoiceBroadcastControl"
class="mx_AccessibleButton mx_VoiceBroadcastControl mx_VoiceBroadcastControl-play"
role="button"
tabindex="0"
>
Expand Down Expand Up @@ -460,7 +460,7 @@ exports[`VoiceBroadcastPlaybackBody when rendering a stopped broadcast should re
>
<div
aria-label="play voice broadcast"
class="mx_AccessibleButton mx_VoiceBroadcastControl"
class="mx_AccessibleButton mx_VoiceBroadcastControl mx_VoiceBroadcastControl-play"
role="button"
tabindex="0"
>
Expand Down