Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Don't double-add events to threads in tests #9742

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Don't double-add events to threads in tests #9742

merged 1 commit into from
Dec 12, 2022

Conversation

duxovni
Copy link
Contributor

@duxovni duxovni commented Dec 12, 2022 •
edited by github-actions bot
Loading

matrix-org/matrix-js-sdk#2951 already adds the events during thread creation.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@duxovni duxovni added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Dec 12, 2022
@duxovni duxovni requested a review from a team as a code owner December 12, 2022 21:55
turt2live
turt2live approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Force-merging to bypass CI (depends on #9741 (circular))

@turt2live turt2live merged commit 47cc8d6 into develop Dec 12, 2022
@turt2live turt2live deleted the fayed/fix-threads-tests branch December 12, 2022 22:43
@clokep clokep mentioned this pull request Dec 15, 2022
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@turt2live turt2live turt2live approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duxovni @turt2live