This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
add concept of platform handling loudNotifications (bings/pings/whatHaveYou) #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aveYou) Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
Can one of the admins verify this patch? |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is so Electron can handle them separately, namely for Win32's flashFrame feature. It started annoying me tripping on every setBadgeCount, I only want it on Loud Notifications
no-op on everything but Electron for now
I guess I could move _playAudioNotification into BasePlatform