This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add credentials when calling bootstrapCrossSigning in Cypress tests #9919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devonh
added
the
T-Task
weeman1337
reviewed
Jan 17, 2023
|
Thanks for the quick review! I've implemented your suggestions and they clean things up a good amount. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dendrite doesn't use the auth shortcut that Synapse uses whereby recently logged in users don't have to re-login when uploading keys. This updates the cypress tests to pass through credentials which are redundant when running with Synapse but required when running with Dendrite.
This change is marked as an internal change (Task), so will not be included in the changelog.