Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Update uniffi version to 0.24.1 #745

Merged
merged 7 commits into from
Jul 26, 2023
Merged

Conversation

aringenbach
Copy link
Contributor

@aringenbach aringenbach commented Jul 21, 2023

Also adds a set of tools to help keep the same version everywhere.

Also rename the ffi crate back to its previous non-standard name to avoid some issues with the Gradle plugin, see https://github.com/matrix-org/matrix-rich-text-editor/blob/main/platforms/android/README.md

Link to Uniffi-rs issue with multiple Rust libraries: mozilla/uniffi-rs#1670

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.86% ⚠️

Comparison is base (3b15882) 90.20% compared to head (d944c1d) 88.34%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #745      +/-   ##
============================================
- Coverage     90.20%   88.34%   -1.86%     
- Complexity        0      269     +269     
============================================
  Files           111      147      +36     
  Lines         16115    17430    +1315     
  Branches        565      789     +224     
============================================
+ Hits          14536    15399     +863     
- Misses         1558     1840     +282     
- Partials         21      191     +170     
Flag Coverage Δ
uitests 73.69% <ø> (-8.65%) ⬇️
uitests-android 64.17% <ø> (?)
uitests-ios 82.34% <ø> (ø)
unittests 88.20% <0.00%> (-0.92%) ⬇️
unittests-android 58.82% <ø> (?)
unittests-ios 80.47% <ø> (ø)
unittests-rust 89.95% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
uniffi-bindgen/src/main.rs 0.00% <0.00%> (ø)

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aringenbach aringenbach requested a review from a team July 24, 2023 08:58
Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'd just like to see a comment about using the UniFFI fork

Cargo.toml Show resolved Hide resolved
bindings/wysiwyg-ffi/README.md Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants