This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
============================================
- Coverage 90.20% 88.34% -1.86%
- Complexity 0 269 +269
============================================
Files 111 147 +36
Lines 16115 17430 +1315
Branches 565 789 +224
============================================
+ Hits 14536 15399 +863
- Misses 1558 1840 +282
- Partials 21 191 +170
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
* Fix Android Rust config * Fix mention test
jonnyandrew
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I'd just like to see a comment about using the UniFFI fork
Kudos, SonarCloud Quality Gate passed! |
jonnyandrew
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a set of tools to help keep the same version everywhere.
Also rename the ffi crate back to its previous non-standard name to avoid some issues with the Gradle plugin, see https://github.com/matrix-org/matrix-rich-text-editor/blob/main/platforms/android/README.md
Link to Uniffi-rs issue with multiple Rust libraries: mozilla/uniffi-rs#1670