This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
Set Swift library to be dynamic #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
============================================
+ Coverage 88.29% 88.73% +0.43%
============================================
Files 153 113 -40
Lines 17795 16207 -1588
Branches 848 597 -251
============================================
- Hits 15712 14381 -1331
+ Misses 1854 1796 -58
+ Partials 229 30 -199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aringenbach
added a commit
that referenced
this pull request
Aug 25, 2023
This reverts commit 5a2cbee.
aringenbach
added a commit
that referenced
this pull request
Aug 25, 2023
This reverts commit 5a2cbee.
aringenbach
added a commit
that referenced
this pull request
Aug 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the Swift library as dynamic should avoid having issues with duplicated symbols.
Note: we are though still using a fork of
uniffi-rsthat solves that issue through renaming, because it also contains mozilla/uniffi-rs#1671 that we currently need in order to build in library mode without library size issues (see #768). I'll create an issue to replace that fork when a version of uniffi containing the fix lands.