Fix unwanted extra paragraphs after HTML parsing

[jonnyandrew]

Problem

The editor may be initialised with arbitrary HTML content however, it currently misbehaves when supplied HTML that contains new lines and indentation.

For example, consider the following HTML snippet:

<p>
  Hello, how are you doing?
</p>

<p>
  I'm fine thanks.
  And you?
</p>

This snippet contains valid HTML but the editor would not understand that the new lines and and spacing are for formatting and indenting the markup, rather than to be displayed as text characters.

The resulting AST contains lots of stray paragraphs and new line characters in the text, which is not correct:

├>p
│ └>"
│   "
├>p
│ └>"
│     Hello, how are you doing?
│   "
├>p
│ └>"
│
│   "
├>p
│ └>"
│     I'm fine thanks.
│     And you?
│   "
└>p
  └>"
            "

Solution

Instead of treating new lines as text, treat new lines (and adjacent spacing) within HTML as indentation:

• Trim surrounding indentation from text
• Replace internal indentation with a single space

After this change, the AST now looks like:

└>p
  └>"Hello, how are you doing?"
└>p
  └>"I'm fine thanks. And you?"

See this JSFiddle example where the same behaviour is shown.

• Fixes Setting content from HTML results in unwanted paragraphs #795

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (0ea1686) 89.85% compared to head (3eaef66) 89.88%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
+ Coverage   89.85%   89.88%   +0.03%     
==========================================
  Files         113       82      -31     
  Lines       16231    14725    -1506     
  Branches      604        0     -604     
==========================================
- Hits        14584    13236    -1348     
+ Misses       1623     1489     -134     
+ Partials       24        0      -24     

Flag	Coverage Δ
uitests	?
uitests-ios	?
unittests	89.88% <100.00%> (+1.32%)	⬆️
unittests-ios	?
unittests-rust	89.88% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
crates/wysiwyg/src/dom/parser/parse.rs	97.93% <100.00%> (+0.03%)	⬆️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information