Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Remove uniffi fork from dependencies (#783) #889

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Nov 23, 2023

This PR closes #783.

The Uniffi fork has been replaced by the latest version of Uniffi (v0.25.2)

@nimau nimau requested a review from andybalaam November 23, 2023 15:21
@andybalaam andybalaam removed their request for review November 23, 2023 16:11
@nimau nimau force-pushed the nicolasm/unfork-uniffi branch from 5943354 to 28e2042 Compare November 23, 2023 16:22
@nimau nimau requested a review from jonnyandrew November 23, 2023 16:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c70a74) 87.43% compared to head (28e2042) 87.44%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #889   +/-   ##
=========================================
  Coverage     87.43%   87.44%           
- Complexity      407      408    +1     
=========================================
  Files           165      165           
  Lines         18952    18952           
  Branches       1043     1043           
=========================================
+ Hits          16571    16572    +1     
+ Misses         2086     2085    -1     
  Partials        295      295           
Flag Coverage Δ
uitests 71.11% <ø> (+0.05%) ⬆️
uitests-android 65.73% <ø> (+0.09%) ⬆️
uitests-ios 78.02% <ø> (ø)
unittests 85.52% <ø> (ø)
unittests-android 45.56% <ø> (ø)
unittests-ios 73.92% <ø> (ø)
unittests-rust 89.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, glad we can do this! I've just started the Android/iOS CI jobs so let's wait for those before merging.

@jonnyandrew
Copy link
Contributor

The checks have passed. I'm not sure why they are not showing on the PR itself but here they are:

@nimau nimau merged commit 98f775c into main Nov 24, 2023
10 checks passed
@nimau nimau deleted the nicolasm/unfork-uniffi branch November 24, 2023 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Uniffi fork when a new version lands
3 participants