Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(indexeddb): Fix implementation of SafeEncode for tuple of 5 elements #1490

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Feb 12, 2023

Regression introduced by merging commit 9707d73 after efdeba7.

Fixes #1489.

Signed-off-by: Kévin Commaille zecakeh@tedomum.fr

Regression introduced by merging commit 9707d73 after efdeba7

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Base: 72.81% // Head: 74.39% // Increases project coverage by +1.58% 🎉

Coverage data is based on head (304b17a) compared to base (b436918).
Patch coverage: 86.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
+ Coverage   72.81%   74.39%   +1.58%     
==========================================
  Files         121      124       +3     
  Lines       13300    13726     +426     
==========================================
+ Hits         9684    10212     +528     
+ Misses       3616     3514     -102     
Impacted Files Coverage Δ
crates/matrix-sdk-base/src/rooms/normal.rs 73.27% <ø> (ø)
crates/matrix-sdk-base/src/session.rs 46.66% <ø> (+7.77%) ⬆️
crates/matrix-sdk-base/src/store/mod.rs 82.50% <ø> (+3.92%) ⬆️
crates/matrix-sdk-crypto/src/olm/account.rs 82.28% <ø> (ø)
crates/matrix-sdk-crypto/src/store/error.rs 0.00% <0.00%> (ø)
crates/matrix-sdk-crypto/src/store/mod.rs 69.18% <ø> (+4.44%) ⬆️
crates/matrix-sdk-sled/src/crypto_store.rs 88.88% <ø> (ø)
crates/matrix-sdk-sqlite/src/error.rs 0.00% <0.00%> (ø)
crates/matrix-sdk/src/client/builder.rs 75.42% <ø> (+4.22%) ⬆️
crates/matrix-sdk/src/client/mod.rs 88.01% <ø> (ø)
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jplatte
Copy link
Collaborator

jplatte commented Feb 12, 2023

Now you're running into #1489 😅

Maybe we should add some #![allow()]s to the affected crates.

@zecakeh
Copy link
Collaborator Author

zecakeh commented Feb 12, 2023

But at least it's not my fault 😛 .

Maybe we should add some #![allow()]s to the affected crates.

Either that or we pin the rust-nightly version?

@jplatte
Copy link
Collaborator

jplatte commented Feb 12, 2023

… or we just wait for rust-lang/rust-clippy#10321 before we merge. If it's merged today, that should be fine 😄

@jplatte
Copy link
Collaborator

jplatte commented Feb 12, 2023

If you want to sort this out now, I think I'd prefer the attributes because they're more obvious and we still get clippy upgrades even if it takes long for the attributes to be removed again.

@zecakeh
Copy link
Collaborator Author

zecakeh commented Feb 12, 2023

It's fine, I'll wait until we're tired of waiting 😁

Triggers false positives.
See discussion in rust-lang/rust-clippy#10319.
Possibly fixed in rust-lang/rust-clippy#10321.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@jplatte jplatte merged commit 96c796b into matrix-org:main Feb 13, 2023
@zecakeh zecakeh deleted the fix-indexeddb-safe-encode branch February 13, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails on main due to new clippy lint
2 participants