Configure Instant wasm polyfill to use monotonic time
#2935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the `inaccurate` feature, this polyfill uses `Date.now()` to emulate `Instant`, which is not monotonic, causing problems like element-hq/element-web#26416.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
==========================================
- Coverage 82.77% 82.74% -0.03%
==========================================
Files 220 220
Lines 22468 22468
==========================================
- Hits 18597 18592 -5
- Misses 3871 3876 +5 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Dec 13, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
inaccuratefeature, this polyfill usesDate.now()to emulateInstant, which is not monotonic, causing problems like element-hq/element-web#26416. Without it, it usesPerformance.now(), which is monotonic.I'm not really sure why we were using
inaccuratein the first place. It was added in #414, but that doesn't seem to be giving any clues.One other point of note:
instantgenerally doesn't seem to be very well maintained (cf sebcrozet/instant#52), and maybe we should useweb-timeas that issue suggests.