Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Share more code when unpickling InboundGroupSessions in sqlite store #3862

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Aug 20, 2024

This is a small refactor that should not affect behaviour in any way.

Part of #3544

@andybalaam andybalaam requested a review from a team as a code owner August 20, 2024 11:44
@andybalaam andybalaam requested review from jmartinesp and removed request for a team August 20, 2024 11:44
crates/matrix-sdk-sqlite/src/crypto_store.rs Outdated Show resolved Hide resolved
@andybalaam andybalaam removed the request for review from jmartinesp August 20, 2024 11:52
@andybalaam andybalaam force-pushed the andybalaam/simplify-igs-in-sqlite branch from ffb7938 to 661b77c Compare August 20, 2024 11:59
@andybalaam andybalaam enabled auto-merge (rebase) August 20, 2024 11:59
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.12%. Comparing base (bbefad3) to head (661b77c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3862      +/-   ##
==========================================
- Coverage   84.13%   84.12%   -0.01%     
==========================================
  Files         261      261              
  Lines       27632    27629       -3     
==========================================
- Hits        23247    23242       -5     
- Misses       4385     4387       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andybalaam andybalaam merged commit 668a267 into main Aug 20, 2024
40 checks passed
@andybalaam andybalaam deleted the andybalaam/simplify-igs-in-sqlite branch August 20, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants