Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Notify when the identity status of a user changes #4022

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Sep 20, 2024

Part of element-hq/element-meta#2526

If you follow the stream returned from matrix_sdk::room::Room::subscribe_to_identity_status_changes you will receive an update every time someone in the room changes identity status e.g. becomes "Unpinned", meaning the UI should display a warning.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 94.96403% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.65%. Comparing base (c9fd5a0) to head (7ebc727).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...x-sdk-crypto/src/identities/room_identity_state.rs 90.27% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4022      +/-   ##
==========================================
+ Coverage   84.57%   84.65%   +0.08%     
==========================================
  Files         267      269       +2     
  Lines       28456    28600     +144     
==========================================
+ Hits        24066    24211     +145     
+ Misses       4390     4389       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andybalaam andybalaam force-pushed the andybalaam/room-identity-stream branch 4 times, most recently from 52bbc70 to e0017c4 Compare September 30, 2024 11:30
@andybalaam andybalaam marked this pull request as ready for review September 30, 2024 11:31
@andybalaam andybalaam requested review from a team as code owners September 30, 2024 11:31
@andybalaam andybalaam requested review from jmartinesp and BillCarsonFr and removed request for a team September 30, 2024 11:31
@andybalaam andybalaam force-pushed the andybalaam/room-identity-stream branch 2 times, most recently from 3db3586 to 0882b3f Compare September 30, 2024 16:28
@richvdh richvdh force-pushed the andybalaam/room-identity-stream branch from 0882b3f to 63798fa Compare October 1, 2024 17:32
@andybalaam
Copy link
Contributor Author

@richvdh not sure what you force-pushed yesterday, but it appeared to delete identity_status_changes.rs so I added it back in a778d5c

@richvdh
Copy link
Member

richvdh commented Oct 2, 2024

@richvdh not sure what you force-pushed yesterday, but it appeared to delete identity_status_changes.rs so I added it back in a778d5c

argh sorry, yes. Failure to git add after a git reset

Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions/comments

Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@andybalaam andybalaam force-pushed the andybalaam/room-identity-stream branch from ff46ff5 to 7ebc727 Compare October 3, 2024 12:02
@andybalaam andybalaam enabled auto-merge (rebase) October 3, 2024 12:02
@andybalaam andybalaam merged commit c5f5bc8 into main Oct 3, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants