-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFI : Add a method in the client to log in using JWT #4056
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4056 +/- ##
=======================================
Coverage 84.55% 84.56%
=======================================
Files 266 266
Lines 28449 28449
=======================================
+ Hits 24055 24057 +2
+ Misses 4394 4392 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. It looks good to me but I left a few comments and formatting needs a bit of work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone please help me with why the fixup comment job is failing?
Also even after running cargo clippy, the formatting is failing.
Need some help to figure it out. I would appreciate it.
That's normal, it's just a reminder to squash the fixup commits before we merge.
You can run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the long commit trail.
Let me know if i should squash all into one/ or should we squash and merge from here when required.
Okay, looks good to me 👍 Please go ahead and squash everything into 1 commit and let's get this merged! |
2f0b30f
to
4c2057f
Compare
Nicely done, thank you for the contribution! |
Thanks for your guidance! Would love to contribute again in the future |
Expose a kotlin method for logging in with JWT.
example usage : This will help users to login to synapse using third party libraries
Tested on the local element app
Signed-off-by:
Pratik Deshpande prattspective@gmail.com