Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFI : Add a method in the client to log in using JWT #4056

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

aristopratt
Copy link
Contributor

Expose a kotlin method for logging in with JWT.
example usage : This will help users to login to synapse using third party libraries

Tested on the local element app

  • Public API changes documented in changelogs (optional)

Signed-off-by:
Pratik Deshpande prattspective@gmail.com

@aristopratt aristopratt requested a review from a team as a code owner October 1, 2024 05:40
@aristopratt aristopratt requested review from stefanceriu and removed request for a team October 1, 2024 05:40
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (dc055c6) to head (4c2057f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4056   +/-   ##
=======================================
  Coverage   84.55%   84.56%           
=======================================
  Files         266      266           
  Lines       28449    28449           
=======================================
+ Hits        24055    24057    +2     
+ Misses       4394     4392    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. It looks good to me but I left a few comments and formatting needs a bit of work

bindings/matrix-sdk-ffi/src/client.rs Outdated Show resolved Hide resolved
bindings/matrix-sdk-ffi/src/client.rs Outdated Show resolved Hide resolved
Copy link
Contributor Author

@aristopratt aristopratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone please help me with why the fixup comment job is failing?
Also even after running cargo clippy, the formatting is failing.
Need some help to figure it out. I would appreciate it.

@poljar
Copy link
Contributor

poljar commented Oct 1, 2024

Can someone please help me with why the fixup comment job is failing?

That's normal, it's just a reminder to squash the fixup commits before we merge.

Also even after running cargo clippy, the formatting is failing. Need some help to figure it out. I would appreciate it.

You can run cargo xtask ci fixup fmt, we use Rust nightly for formatting.

Copy link
Contributor Author

@aristopratt aristopratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the long commit trail.

Let me know if i should squash all into one/ or should we squash and merge from here when required.

@stefanceriu
Copy link
Member

Okay, looks good to me 👍 Please go ahead and squash everything into 1 commit and let's get this merged!

@stefanceriu stefanceriu enabled auto-merge (rebase) October 1, 2024 09:17
@stefanceriu stefanceriu merged commit f7d99cc into matrix-org:main Oct 1, 2024
40 checks passed
@stefanceriu
Copy link
Member

Nicely done, thank you for the contribution!

@aristopratt
Copy link
Contributor Author

Nicely done, thank you for the contribution!

Thanks for your guidance! Would love to contribute again in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants