-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC1849: Proposal for m.relates_to aggregations #1849
Closed
Closed
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
0b5dab5
a very WIP draft of an aggregations MSC to replace #441
ara4n e03457d
incorporate notes from sync with erik
ara4n 8567149
shower thoughts
ara4n ed2a3a0
more notes from today's sync with erik
ara4n 07050a4
Update with new proposal
erikjohnston 25b879b
fixup
erikjohnston f50de1f
Add some notes about extended annotations
erikjohnston ebb25e0
further updates from RLing with Erik
ara4n 7db56e1
Merge branch 'master' of github.com:matrix-org/matrix-doc into matthe…
erikjohnston a9d2efa
Fix spacing
erikjohnston c47391e
Add proposed pagination API
erikjohnston 1b24334
Flesh out the pagination API a bit
erikjohnston a12db5b
following RL review
ara4n 3255ae0
Add edit example
erikjohnston e0f165e
Example has been added
erikjohnston d38d7a7
try to converge towards a proper reviewable draft
ara4n 08de484
yet more notes on yet more edge cases
ara4n e78e7ad
Add a coherent overview; remove a bunch of FIXMEs
ara4n dacae1f
Add TOC
ara4n 5375a23
markdown tweaks
ara4n 0f7cf5e
typos
ara4n 4bb8d6b
s/contents/content/g
ara4n 60a3d61
fix wording
ara4n 117ae97
Update proposals/1849-aggregations.md
ara4n 8627fb7
Update proposals/1849-aggregations.md
ara4n 2dde2c1
add m.new_content
ara4n b166d6c
Merge branch 'master' into matthew/msc1849
ara4n adb240d
WIP commit of rewrite to MSC1849
ara4n a6c8b65
WIP commit of rewrite to MSC1849
ara4n 081ea3d
write up the new gappy sync stuff
ara4n 9c90cc1
s/stale_relations/stale_events/
ara4n 3f3d60e
rewrite the paginations section
ara4n d98d5b3
finish rewriting MSC1849, in theory, incorporating all review so far
ara4n c313489
Merge pull request #2154 from matrix-org/matthew/msc1849-rewrite
ara4n fa7c338
fix typos
ara4n 1409119
Update proposals/1849-aggregations.md
ara4n e8fde9d
Update proposals/1849-aggregations.md
ara4n 4d236c6
incorporate some of the PR review
ara4n f63b20a
remaining review
ara4n b228688
clarify `m.replace` bundle structure
ara4n fb4446f
wording tweaks
ara4n 6225aae
Apply suggestions from code review
ara4n 6751de6
PR review
ara4n eab778d
clarify ignored users
ara4n a63d27e
incorporate erik feedback
ara4n 4e8d370
POST /event
ara4n e816233
clarify errors on /aggregations
ara4n 4a96865
add bruno's local echo considerations
ara4n e57033a
arbitrarily restrict trailing slashes for now
ara4n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when the set of relations becomes very large?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent question. god knows; this is being swept under the carpet for now.