Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2625: Add mark_unread push rule action #2625

Closed
wants to merge 5 commits into from
Closed

MSC2625: Add mark_unread push rule action #2625

wants to merge 5 commits into from

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 10, 2020 •
edited
Loading

@richvdh richvdh added proposal A matrix spec change proposal proposal-in-review labels Jun 10, 2020
@turt2live turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Jun 10, 2020
@richvdh richvdh mentioned this pull request Jun 10, 2020
Closed
This was referenced Jun 10, 2020
Closed
Merged
@babolivier
Copy link
Contributor

Synapse implementation: matrix-org/synapse#7673

richvdh and others added 2 commits June 11, 2020 11:59
@turt2live turt2live self-requested a review June 11, 2020 16:30
babolivier added a commit to matrix-org/synapse that referenced this pull request Jun 17, 2020
@babolivier
Implement unread counter (MSC2625) (#7673)
46613aa 
Implementation of matrix-org/matrix-spec-proposals#2625
This was referenced Jun 23, 2020
Open
Open
turt2live
turt2live approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit quicker to do, albeit risking further confusion and concern with the push rules system. It's a bit questionable to let users decide what counts as something worth marking as unread, and different clients may have different opinions on that anyways.

@richvdh
Copy link
Member Author

richvdh commented Jul 1, 2020

sorry, I should have said: this is being superceded by #2654. Trying to get both "unread" and "notifications" out of the same list of push rules was a nightmare.

@richvdh richvdh closed this Jul 1, 2020
@turt2live turt2live added abandoned A proposal where the author/shepherd is not responsive and removed proposal-in-review labels Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ara4n ara4n ara4n left review comments

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
abandoned A proposal where the author/shepherd is not responsive kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richvdh @babolivier @turt2live @ara4n