Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3173: Expose stripped state events to any potential joiner #3173

Merged
merged 19 commits into from
Jun 20, 2021
Merged

MSC3173: Expose stripped state events to any potential joiner #3173

merged 19 commits into from
Jun 20, 2021

Conversation

clokep
Copy link
Member

@clokep clokep commented May 3, 2021 •
edited
Loading

@clokep clokep changed the title [WIP] MSCXXXX: Expose stripped state events to any potential joiner [WIP] MSC3173: Expose stripped state events to any potential joiner May 3, 2021
@turt2live turt2live marked this pull request as draft May 3, 2021 17:37
@turt2live turt2live added client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal labels May 3, 2021
@clokep clokep mentioned this pull request May 3, 2021
Merged
@clokep clokep changed the title [WIP] MSC3173: Expose stripped state events to any potential joiner MSC3173: Expose stripped state events to any potential joiner May 12, 2021
@clokep clokep marked this pull request as ready for review May 12, 2021 14:34
@clokep
Copy link
Member Author

clokep commented May 12, 2021

Since this is pretty much a clarification / expansion of current behavior, I don't think this really needs an implementation since...the current implementations already implement this. 😄

@turt2live turt2live self-requested a review May 12, 2021 14:37
turt2live
turt2live reviewed May 14, 2021
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems sane. It's a bit awkward that the MSC says the user can access the stripped state, but doesn't really describe how the user might encounter those events. Dedicated endpoints are probably still out of scope for this MSC, but some clarification around the unification of stripped state and when they might appear (potentially in future MSCs) would be appreciated.

proposals/3173-expose-stripped-state-events.md Outdated Show resolved Hide resolved
proposals/3173-expose-stripped-state-events.md Outdated Show resolved Hide resolved
proposals/3173-expose-stripped-state-events.md Outdated Show resolved Hide resolved
proposals/3173-expose-stripped-state-events.md Outdated Show resolved Hide resolved
@turt2live turt2live merged commit ecd28fe into master Jun 20, 2021
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jun 20, 2021
This was referenced Jun 25, 2021
Closed
Merged
haslersn
haslersn reviewed Jul 9, 2021
View reviewed changes
proposals/3173-expose-stripped-state-events.md
receive stripped state events to display metadata to users.

This MSC proposes formalizing that the stripped state that is currently available
to invited and knocking users is available to any user who could potentially join
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is “potentially join” recursive? I.e., if I'm in A, which allows joining B, which allows joining C, can I potentially join C?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the purposes of this MSC, no. Recursion like that would be determined in another access control MSC.

@deepbluev7 deepbluev7 mentioned this pull request Jul 20, 2021
Merged
@clokep clokep mentioned this pull request Aug 11, 2021
Merged
richvdh pushed a commit that referenced this pull request Aug 23, 2021
@turt2live @richvdh
Merge pull request #3173 from matrix-org/clokep/stripped-state
6d8417f 
MSC3173: Expose stripped state events to any potential joiner
richvdh pushed a commit that referenced this pull request Aug 27, 2021
@turt2live @richvdh
Merge pull request #3173 from matrix-org/clokep/stripped-state
87d2239 
MSC3173: Expose stripped state events to any potential joiner
@turt2live turt2live mentioned this pull request Sep 24, 2021
Closed
@clokep clokep mentioned this pull request Oct 26, 2021
Open
turt2live added a commit that referenced this pull request Dec 29, 2021
@turt2live
Describe and hoist stripped state to a first-class citizen
46b977c 
Fixes #3413
MSC: #3173
@turt2live turt2live mentioned this pull request Dec 29, 2021
Merged
@turt2live
Copy link
Member

Spec PR: #3606

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Dec 29, 2021
@clokep clokep mentioned this pull request Dec 30, 2021
Merged
turt2live added a commit that referenced this pull request Jan 5, 2022
@turt2live
Describe and hoist stripped state to a first-class citizen (#3606)
56532dd 
* Describe and hoist stripped state to a first-class citizen

Fixes #3413
MSC: #3173

* Add changelog

* may->can for clarity

* Update text per review
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jan 5, 2022
@clokep clokep mentioned this pull request May 28, 2022
Closed
@clokep clokep deleted the clokep/stripped-state branch May 17, 2023 12:23
@matrixbot matrixbot mentioned this pull request Dec 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslersn haslersn haslersn left review comments

@sumnerevans sumnerevans sumnerevans left review comments

@erkinalp erkinalp erkinalp approved these changes

@t3chguy t3chguy t3chguy left review comments

@richvdh richvdh richvdh left review comments

@turt2live turt2live turt2live approved these changes

@uhoreg uhoreg uhoreg left review comments

@kevincox kevincox kevincox approved these changes

Assignees

@turt2live turt2live

Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.