Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3939: Account locking #3939

Merged
merged 12 commits into from
May 10, 2024
Merged

MSC3939: Account locking #3939

merged 12 commits into from
May 10, 2024

Conversation

babolivier
Copy link
Contributor

@babolivier babolivier commented Nov 24, 2022 •
edited by turt2live
Loading

@babolivier babolivier changed the title MSCXXXX: Account locking MSC3939: Account locking Nov 24, 2022
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Nov 24, 2022
@aceArt-GmbH

This comment was marked as resolved.

Sign in to view
@babolivier
Copy link
Contributor Author

Seems to overlap a bit with #3823 ;)

See the Alternatives section :)

Also please write comments on MSCs in threads to prevent clottering the timeline 😅

@MadLittleMods MadLittleMods mentioned this pull request Apr 15, 2023
Closed
@babolivier
Copy link
Contributor Author

babolivier commented Jul 3, 2023 •
edited
Loading

PSA: I don't really wish to spend time maintaining this MSC anymore (as it was written in the context of work related to a role I no longer hold; plus I don't have write access to this branch anymore). This MSC should be considered unmaintained/abandoned unless someone else wishes to take it over (in which case, be my guest).

@MatMaul MatMaul mentioned this pull request Jul 5, 2023
Merged
4 tasks
@MatMaul
Copy link

MatMaul commented Jul 5, 2023

Thanks for your work @babolivier. I am going to take this over.

@MatMaul
Copy link

MatMaul commented Aug 16, 2023

An implementation has been merged in synapse and will be available in synapse 1.91.

This was referenced Sep 21, 2023
Open
Merged
@turt2live
Copy link
Member

Aside from some editorial comments, I think this is largely ready to go.

SCT members should feel welcome to comment on the user directory thread.

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Nov 27, 2023 •
edited by KitsuneRal
Loading

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

  • 401/403 behaviour
  • general clarity

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Nov 27, 2023
@turt2live turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Nov 27, 2023
dbkr
dbkr reviewed Nov 28, 2023
View reviewed changes
proposals/3939-account-locking.md Outdated Show resolved Hide resolved
proposals/3939-account-locking.md Outdated Show resolved Hide resolved
proposals/3939-account-locking.md Outdated Show resolved Hide resolved
proposals/3939-account-locking.md Outdated Show resolved Hide resolved
proposals/3939-account-locking.md Outdated Show resolved Hide resolved
proposals/3939-account-locking.md Outdated Show resolved Hide resolved
@dbkr
Copy link
Member

dbkr commented Nov 28, 2023

@mscbot concern 401/403 behaviour

@mscbot mscbot added the unresolved-concerns This proposal has at least one outstanding concern label Nov 28, 2023
@dbkr
Copy link
Member

dbkr commented Nov 28, 2023 •
edited
Loading

@mscbot concern general clarity

#3939 (comment) mostly

dklimpel
dklimpel reviewed Nov 28, 2023
View reviewed changes
proposals/3939-account-locking.md Outdated Show resolved Hide resolved
proposals/3939-account-locking.md Show resolved Hide resolved
@turt2live turt2live removed the unresolved-concerns This proposal has at least one outstanding concern label Apr 1, 2024
@turt2live
Copy link
Member

I've manually resolved the concerns for now.

@turt2live turt2live mentioned this pull request Apr 1, 2024
Open
uhoreg
uhoreg reviewed Apr 3, 2024
View reviewed changes
proposals/3939-account-locking.md Outdated Show resolved Hide resolved
proposals/3939-account-locking.md Show resolved Hide resolved
@turt2live @uhoreg
Update proposals/3939-account-locking.md
a10802d 
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
@turt2live @uhoreg
Update proposals/3939-account-locking.md
f76d53a 
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
@mscbot
Copy link
Collaborator

mscbot commented May 4, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 4, 2024
@mscbot
Copy link
Collaborator

mscbot commented May 9, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels May 9, 2024
@turt2live turt2live merged commit 8eb75fe into main May 10, 2024
1 check passed
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels May 10, 2024
@Johennes Johennes mentioned this pull request Aug 20, 2024
Merged
3 tasks
@Johennes
Copy link
Contributor

Spec PR: matrix-org/matrix-spec#1934

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Aug 28, 2024
This was referenced Sep 29, 2024
Closed
Merged
@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Sep 30, 2024
@turt2live
Copy link
Member

Merged 🎉

This was referenced Oct 8, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal left review comments

@dklimpel dklimpel dklimpel left review comments

@tulir tulir tulir left review comments

@MatMaul MatMaul MatMaul left review comments

@richvdh richvdh richvdh left review comments

@turt2live turt2live turt2live left review comments

@uhoreg uhoreg uhoreg left review comments

@MadLittleMods MadLittleMods MadLittleMods left review comments

@dbkr dbkr Awaiting requested review from dbkr

Assignees

@turt2live turt2live

Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Backlog
Status: Done to some definition
[Temp] SCT MSC intake board
Status: Scheduled - v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.