-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec MSC2285: Private read receipts #1216
Conversation
Apparently it hates it when you do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you!
while we appreciate the support, approving PRs like this does not help them move faster :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with minor quibbles. very pleasing to see what a simple diff it is in the end to the spec itself :)
Co-authored-by: Matthew Hodgson <matthew@matrix.org>
Markdown (used as reference due to post-FCP edits): https://github.com/matrix-org/matrix-spec-proposals/blob/main/proposals/2285-hidden-read-receipts.md
MSC: matrix-org/matrix-spec-proposals#2285
Requires matrix-org/matrix-spec-proposals#3875
Reviewer: This is best reviewed commit-by-commit.
Preview: https://pr1216--matrix-spec-previews.netlify.app