-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the font
HTML tag
#1739
Conversation
Rationale: MSC4077 allows to deprecate HTML tags that are deprecated in the WHATWG standard, if they can be replaced by tags with the same feature. `font` is deprecated and can be replaced by `span` with the `data-mx-bg-color` and `data-mx-color` attributes. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
It might still be a good idea to remove it, but I think it'd be good to have a note saying it was previously allowed. Maybe mark it as deprecated somehow instead of removing entirely |
A note saying that clients should stop using |
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
I added an info box for the deprecation. |
The font tag may be deprecated soon (matrix-org/matrix-spec#1739) Signed-off-by: Tulir Asokan <tulir@maunium.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine now, but I'm not completely sure if it should require an MSC due to being used by many clients
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Given that the change in the clients is quite straightforward, I don't think we should hold back this change. After all, the whole HTML subset is recommended, not mandatory, and cases of similar minor non-compliance have happened and will happen. But I'd appreciate a third opinion from another client author, out of caution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a terribly active client dev myself these days, but the change seems reasonable given the context. Clients are asked to prefer span
, but we aren't breaking anything.
Opening issues on a few clients would be appreciated, but not required. This might be an SCT responsibility to encourage the ecosystem to upgrade anyways.
* Use data-mx-color for rainbows The font tag may be deprecated soon (matrix-org/matrix-spec#1739) Signed-off-by: Tulir Asokan <tulir@maunium.net> * Update tests Signed-off-by: Tulir Asokan <tulir@maunium.net> --------- Signed-off-by: Tulir Asokan <tulir@maunium.net>
Rationale:
MSC4077 allows to deprecate HTML tags that are deprecated in the WHATWG standard without requiring an MSC, if they can be replaced by tags with the same feature.
font
is deprecated and can be replaced byspan
with thedata-mx-bg-color
anddata-mx-color
attributes.So, HTML like this:
Can also be written like this:
Preview: https://pr1739--matrix-spec-previews.netlify.app