-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2ee/device verification: clarifications #1830
base: main
Are you sure you want to change the base?
e2ee/device verification: clarifications #1830
Commits on May 30, 2024
-
e2ee/device verification: move general error handling under framework
Most of the "Error and exception handling" section is generally applicable to other verification methods besides SAS, so I moved those bullet points under "Key verification framework". Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for 0872ec7 - Browse repository at this point
Copy the full SHA 0872ec7View commit details -
e2ee/device verification/error handling: fix typo start -> request
It used to be possible to create a start request without a request, but this was deprecated. Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for 01a816d - Browse repository at this point
Copy the full SHA 01a816dView commit details -
m.key.verification.start: remove wording that it is typically to-device
It can be either a to-device event or an in-room event. Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for 8905029 - Browse repository at this point
Copy the full SHA 8905029View commit details -
Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for b8808ca - Browse repository at this point
Copy the full SHA b8808caView commit details
Commits on Jun 7, 2024
-
fixup! e2ee/device verification: move general error handling under fr…
…amework Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ea9dc84 - Browse repository at this point
Copy the full SHA ea9dc84View commit details -
fixup! e2ee/device verification: move general error handling under fr…
…amework Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for edc4f38 - Browse repository at this point
Copy the full SHA edc4f38View commit details -
fixup! e2ee/device verification: move general error handling under fr…
…amework Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3fbb048 - Browse repository at this point
Copy the full SHA 3fbb048View commit details -
fixup! e2ee/device verification: move general error handling under fr…
…amework Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for d6c6a03 - Browse repository at this point
Copy the full SHA d6c6a03View commit details -
fixup! e2ee/device verification: move general error handling under fr…
…amework Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for 2ea4e13 - Browse repository at this point
Copy the full SHA 2ea4e13View commit details -
fixup! e2ee/device verification: move general error handling under fr…
…amework Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for d66a805 - Browse repository at this point
Copy the full SHA d66a805View commit details -
fixup! e2ee/device verification: move general error handling under fr…
…amework Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for 55375f4 - Browse repository at this point
Copy the full SHA 55375f4View commit details -
fixup! e2ee/device verification: move general error handling under fr…
…amework Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for d10deb0 - Browse repository at this point
Copy the full SHA d10deb0View commit details -
e2ee/device verification: normalize all links
This commit changes the format of all links in the Device Verification section to be: [`m.key.verification.whatever`](#mkeyverificationwhatever) This involved adding links in a bunch of places, but also changing many links that did not have code within them to have the backticks. Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for b87ffa6 - Browse repository at this point
Copy the full SHA b87ffa6View commit details -
Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for a79d5a6 - Browse repository at this point
Copy the full SHA a79d5a6View commit details -
e2ee/device verification start: clarify required nature of transactio…
…n_id or m.relates_to Add notes about the fact that the start event *may* be the first event sent during a verification process and that clients should handle other clients doing so, but not themselves send the start event first. Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for 4282a1a - Browse repository at this point
Copy the full SHA 4282a1aView commit details -
fixup! e2ee/device verification: normalize all links
Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for a9350fc - Browse repository at this point
Copy the full SHA a9350fcView commit details