Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2ee/device verification: clarifications #1830

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Commits on May 30, 2024

  1. e2ee/device verification: move general error handling under framework

    Most of the "Error and exception handling" section is generally
    applicable to other verification methods besides SAS, so I moved those
    bullet points under "Key verification framework".
    
    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed May 30, 2024
    Configuration menu
    Copy the full SHA
    0872ec7 View commit details
    Browse the repository at this point in the history
  2. e2ee/device verification/error handling: fix typo start -> request

    It used to be possible to create a start request without a request, but
    this was deprecated.
    
    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed May 30, 2024
    Configuration menu
    Copy the full SHA
    01a816d View commit details
    Browse the repository at this point in the history
  3. m.key.verification.start: remove wording that it is typically to-device

    It can be either a to-device event or an in-room event.
    
    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed May 30, 2024
    Configuration menu
    Copy the full SHA
    8905029 View commit details
    Browse the repository at this point in the history
  4. Add changelog

    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed May 30, 2024
    Configuration menu
    Copy the full SHA
    b8808ca View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. fixup! e2ee/device verification: move general error handling under fr…

    …amework
    
    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    sumnerevans and richvdh authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    ea9dc84 View commit details
    Browse the repository at this point in the history
  2. fixup! e2ee/device verification: move general error handling under fr…

    …amework
    
    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    sumnerevans and richvdh authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    edc4f38 View commit details
    Browse the repository at this point in the history
  3. fixup! e2ee/device verification: move general error handling under fr…

    …amework
    
    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    sumnerevans and richvdh authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    3fbb048 View commit details
    Browse the repository at this point in the history
  4. fixup! e2ee/device verification: move general error handling under fr…

    …amework
    
    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d6c6a03 View commit details
    Browse the repository at this point in the history
  5. fixup! e2ee/device verification: move general error handling under fr…

    …amework
    
    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    2ea4e13 View commit details
    Browse the repository at this point in the history
  6. fixup! e2ee/device verification: move general error handling under fr…

    …amework
    
    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d66a805 View commit details
    Browse the repository at this point in the history
  7. fixup! e2ee/device verification: move general error handling under fr…

    …amework
    
    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    55375f4 View commit details
    Browse the repository at this point in the history
  8. fixup! e2ee/device verification: move general error handling under fr…

    …amework
    
    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d10deb0 View commit details
    Browse the repository at this point in the history
  9. e2ee/device verification: normalize all links

    This commit changes the format of all links in the Device Verification
    section to be:
    
        [`m.key.verification.whatever`](#mkeyverificationwhatever)
    
    This involved adding links in a bunch of places, but also changing many
    links that did not have code within them to have the backticks.
    
    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    b87ffa6 View commit details
    Browse the repository at this point in the history
  10. fixup! Add changelog

    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    a79d5a6 View commit details
    Browse the repository at this point in the history
  11. e2ee/device verification start: clarify required nature of transactio…

    …n_id or m.relates_to
    
    Add notes about the fact that the start event *may* be the first event
    sent during a verification process and that clients should handle other
    clients doing so, but not themselves send the start event first.
    
    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    4282a1a View commit details
    Browse the repository at this point in the history
  12. fixup! e2ee/device verification: normalize all links

    Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
    sumnerevans committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    a9350fc View commit details
    Browse the repository at this point in the history