-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide MD checklists for the changelog #1937
Conversation
Fixes: matrix-org#1682 Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
It seems strange to me to have the same content twice in "Changelog" and in the different versions. This also complicates the rendering because the levels of the headings should be different in both cases. Maybe clicking on "Changelog" could just open the latest version? |
I like that, yeah. I was worried that changing that page would break existing links. However, I'm now realizing any existing link (such as https://spec.matrix.org/v1.11/changelog/#internal-changestooling) would point into a historic spec version anyway. So this seems like a non-issue. 🤦 |
Have made it so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed this entirely because the added info felt superfluous. Every changelog lists changes made since the last release and the version is apparent via the URL and page heading.
Thanks, it looks good. I like that when we hover a version in the sidebar, there's the full title that appears. I am not a fan of the redirect on the "Changelog" page, I would prefer for the link to be the correct one, but I guess there is no simple way to do that with Hugo. |
Yeah, it's not pretty, especially because the index page briefly flashes before redirecting. Maybe we could render the latest version's changelog inline on the index page instead? That would effectively make |
{{ with index .Page.RegularPages.ByDate.Reverse 0 }} | ||
<meta http-equiv="refresh" content="0; url={{ .Permalink }}" /> | ||
{{ end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could add something like:
manualLinkRelRef: unstable.md
to the front matter of content/changelog/_index.html
, but it would need maintaining during releases. (We could hack the generate-changelog.sh
script to update it?)
Or we could add more intelligence to layouts/partials/sidebar-tree.html
to handle this case?
This is probably fine for now, and we could improve it in a future PR.
I'm inclined to merge this if there are no pressing objections from other SCT members. |
(I like breaking the changelog up into pages, irrespective of any benefits from the checklist) |
I'm a fan of the output, but haven't checked the implementation. |
Let's ship it then |
This appears to have generated broken links on the live site: https://github.com/matrix-org/matrix-spec/actions/runs/11070201829/job/30759445748#step:6:13 |
Hm, looks like these are from
Locally these look fine for me though:
🤔 |
I've opened #1954 to remove these links entirely. |
It's not the only URLs that are affected, the one from the |
Basically, the problem seems to be the use of |
Ah, I missed this. Thanks @zecakeh! Looks like |
Fixes: #1682
This changes
/changelog
to be a section and adds a separate output format to provide Markdown checklists under/changelog/$VERSION/checklist.md
.Example:
I've also added links to the checklists in each version's header table.
Since each version's changelog has a separate page now, inlining all changelogs on the index page seemed superfluous. Similarly, having the index page only list historical spec versions felt odd. Therefore, I've moved the info about historical versions to its own page and made the index page redirect to the latest version's changelog page.
Pull Request Checklist
Preview: https://pr1937--matrix-spec-previews.netlify.app