Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gen-i18n to use nested object pluralisation format #7

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Update gen-i18n to use nested object pluralisation format #7

merged 1 commit into from
Aug 16, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 15, 2023 •
edited
Loading

For element-hq/element-web#25608

Switches from "key|plural": "string" form to "key": { "plural": "string" }

@t3chguy t3chguy requested a review from a team as a code owner August 15, 2023 14:57
This was referenced Aug 15, 2023
Merged
Merged
Merged
Closed
@t3chguy t3chguy self-assigned this Aug 15, 2023
andybalaam
andybalaam approved these changes Aug 16, 2023
View reviewed changes
Copy link

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be easier for me to understand if there were tests, but I'm not going to insist because the overhead of adding a test framework might be too much of a sidetrack for this change.

@t3chguy t3chguy merged commit 24fc4db into main Aug 16, 2023
1 check passed
@t3chguy t3chguy deleted the t3chguy/localazy-0 branch August 16, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@richvdh richvdh Awaiting requested review from richvdh richvdh was automatically assigned from matrix-org/element-web-reviewers

@SimonBrandner SimonBrandner Awaiting requested review from SimonBrandner SimonBrandner was automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @andybalaam