Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions from the widget driver in the event relations endpoint #73

Merged

Conversation

dhenneke
Copy link
Contributor

@dhenneke dhenneke commented Sep 7, 2022

This is a follow up to #72.

The driver can throw an exception, e.g. when the referenced event doesn't exist or when the user is not authorized to see it due to the configured history visibility rules. Without this change, the call times out because the error is not forwarded via the transport channel.

Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
@dhenneke dhenneke marked this pull request as ready for review September 7, 2022 15:00
@dhenneke dhenneke requested a review from a team as a code owner September 7, 2022 15:00
@dhenneke dhenneke requested review from andybalaam, t3chguy and robintown and removed request for a team September 7, 2022 15:00
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/ClientWidgetApi.ts Outdated Show resolved Hide resolved
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
@robintown robintown merged commit aa9496b into matrix-org:master Sep 7, 2022
@dhenneke dhenneke deleted the nic/feat/relations-exception-fix branch September 7, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants