Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MSC3973: Search users in the user directory with the Widget API #79

Merged

Conversation

dhenneke
Copy link
Contributor

@dhenneke dhenneke commented Mar 1, 2023

…MSC3973

Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
@t3chguy
Copy link
Member

t3chguy commented Mar 6, 2023

Not sure if matrix-widget-api has been made willing to be a playground to implement MSCs upon, deferring to tech lead @andybalaam

@t3chguy t3chguy removed their request for review March 6, 2023 19:06
@dhenneke
Copy link
Contributor Author

dhenneke commented Mar 7, 2023

I added more information about the security implications of this change to the linked MSC.

@andybalaam
Copy link
Member

I missed the notification about this ping, sorry. I'll try to look into this tomorrow.

@andybalaam
Copy link
Member

Apologies, I am looking at this today.

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the contribution.

@andybalaam andybalaam merged commit 9e2acc8 into matrix-org:master Mar 17, 2023
@andybalaam
Copy link
Member

Now available in release 1.3.0

@dhenneke
Copy link
Contributor Author

Thanks. I will update my other PR in the react-sdk to consume the new version of the widget-api.

@dhenneke dhenneke deleted the nic/feat/widgetapi-user-directory-search branch March 17, 2023 12:06
@Johennes Johennes added the A-Timesheet-1 Log any time spent on this into the A-Timesheet-1 project label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timesheet-1 Log any time spent on this into the A-Timesheet-1 project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants