Add a warning if contentLoaded event isn't received #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the widget fails less silently if waitForIFrameLoad=false is specified but the widget doesn't send the contentLoaded event, to help prevent people like me being daft and wasting ages because they reverted one bit of code and not the other.
dbkr
requested review from
andybalaam and
robintown
and removed request for
a team
robintown
approved these changes
Jul 12, 2023
toger5
approved these changes
Jul 12, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the widget fails less silently if waitForIFrameLoad=false is specified but the widget doesn't send the contentLoaded event, to help prevent people like me being daft and wasting ages because they reverted one bit of code and not the other.
Also fixes a couple of typos.