🚀 Publish PR previews on netlify #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 6, 2021 08:38
Signed-off-by: Alexandre Franke <alexandre.franke@matrix.org>
GHA doesn’t like double quotes here apparently actions/runner#866
|
As can be seen in the above description, It Works™! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… but do it as part of the existing workflow this time.
The code is obviously cleaner than in #1088 as splitting the workflows creates a lot of overhead. We should probably merge this one.
Preview: https://pr1089--matrix-org-previews.netlify.app