Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel concurrent GHA builds #1510

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Cancel concurrent GHA builds #1510

merged 1 commit into from
Oct 21, 2022

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Oct 18, 2022

This is a thing we do on Synapse, and it makes things build faster by not tying up GHA workers with builds we don't care about.

Preview: https://pr1510--matrix-org-previews.netlify.app

This is a thing we do on Synapse, and it makes things build faster by not tying up GHA workers with builds we don't care about.
@thibaultamartin
Copy link
Contributor

Will the default branch always have preference? Or can a PR cancel a build triggered from merging something into master?

@richvdh
Copy link
Member Author

richvdh commented Oct 21, 2022

oh, sorry, I explained this badly. Only builds on the same branch will be cancelled. So each PR is independent, as is master.

Copy link
Contributor

@thibaultamartin thibaultamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm then :)

@richvdh richvdh merged commit e31b5f6 into master Oct 21, 2022
@richvdh richvdh deleted the rav/cancel_concurrent_builds branch October 21, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants