Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze the current appendices.html file for the legacy spec #964

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

anoadragon453
Copy link
Member

This PR is part of unfreezing the spec as a whole after the spec redesign has launched: matrix-org/matrix-spec-proposals#3055

Essentially we'd like to redirect the unstable versions of the old spec to the new spec site (https://spec.matrix.org). Unfortunately, we can't do that for the appendices page as there is no stable vs. unstable appendices page. It's never been versioned. As such, if we redirected it then any links to the appendices in the stable versions of the legacy spec would take you to the appendices page on the new spec - which would be very weird.

Thus, this PR freezes the appendices page in time. We'll be setting up redirects for all of the /unstable spec pages, as well as the /proposals page, as with the former the user consciously chooses to view the unstable spec, and in the latter the proposals page is a living document which isn't deep-linked into by the spec.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ctrl+f'd the appendices.html for steal and hack

@anoadragon453
Copy link
Member Author

anoadragon453 commented Mar 16, 2021

One could also download the generated styled-docs.tar.gz from the build and check to see if appendices is in there. But that works too.

@anoadragon453 anoadragon453 merged commit b49605e into master Mar 16, 2021
@afranke afranke deleted the anoa/appendices_freeze branch September 13, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants