Initial MSC3266 implementation with tweaks for displaying Spaces #219
Conversation
There was a problem hiding this comment.
I'm sure the code is fine, but the mix of tabs and spaces makes this aggravating to review. Please fix it across the whole project, as I can see historical diffs with tabs/spaces issues as well - I'd rather one PR be overloaded than review this indentation nightmare.
|
Going to hold off landing this until Synapse has support for it, as it does add an additional API hit so a tiny bit of delay to HSes without support for this API - it is negligible but we gain nothing from landing it early |
|
The Synapse MSC is getting close and I'm going on holiday, merging now, no rush on deploy, will create a card re deploying closer to go live |
|
FYI the required APIs are now live on matrix.org, it sounds like we'll want to wait for it to be in a release version before deploying though since (I think) matrix.to hits various homeservers? |
|
Yes, the first time you use matrix.to we ask you which homeserver to use to show previews..
(to be honest, this doesn't seem worth the likely drop-off just to show summaries ..) |
|
the idea is that the "use matrix.org?" dialog should feel no more or less invasive than a GDPR click-thru fwiw. previews are pretty important UX though - in terms of room name, avatar, etc, otherwise it could just come up with a raw ID which is horrific. |
Fixes #213
Fixes #214
Implements matrix-org/matrix-spec-proposals#3266