This repository has been archived by the owner on Nov 25, 2022. It is now read-only.
Run some of the synapse tests against python 3.8/postgres 12 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
approved these changes
Jan 10, 2020
| @@ -183,7 +189,7 @@ steps: | |||
| - exit_status: 2 | |||
| limit: 2 | |||
|
|
|||
| - label: ":python: 3.7 / :postgres: 9.5" | |||
| - label: ":python: 3.7 / :postgres: 11" | |||
There was a problem hiding this comment.
Why this change? Why are we testing pg11?
There was a problem hiding this comment.
Github isn't doing the best job of showing a sensible diff.
I was thinking it would be sensible to test against a range of postgres versions rather than just min and max, hence I'm suggesting we retain the current tests against py3.7/pg11.
Rather, I'm replacing the tests against py3.7/pg9.5 with tests against py3.8/pg12; the rationale being that we already testing against pg9.5 (in the py3.5/pg9.5 tests), and I'm not super-keen to introduce even more test runs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.