Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding of \u2028 and \u2029 is incorrect #2

Closed
richvdh opened this issue Mar 23, 2018 · 0 comments · Fixed by #9
Closed

encoding of \u2028 and \u2029 is incorrect #2

richvdh opened this issue Mar 23, 2018 · 0 comments · Fixed by #9

Comments

@richvdh
Copy link
Member

richvdh commented Mar 23, 2018

the spec says that \u2028 (line separator) should be encoded as the UTF-8 \xe2\x80\xa8, however python-canonicaljson encodes it as the \u-escaped version.

This is largely thanks to simplejson/simplejson#206.
richvdh added a commit that referenced this issue Mar 28, 2018
@richvdh
Encode with ensure_ascii=True and then fix
3fe8207 
This turns out to be way quicker. It also allows us to fix #2.
@richvdh richvdh mentioned this issue Mar 28, 2018
Merged
richvdh added a commit that referenced this issue Mar 28, 2018
@richvdh
Encode with ensure_ascii=True and then fix
5d24666 
This turns out to be way quicker. It also allows us to fix #2.
richvdh added a commit that referenced this issue Mar 28, 2018
@richvdh
Encode with ensure_ascii=True and then fix
9b75c0d 
This turns out to be way quicker. It also allows us to fix #2.
richvdh added a commit that referenced this issue Mar 28, 2018
@richvdh
Encode with ensure_ascii=True and then fix
2b9c51d 
This turns out to be way quicker. It also allows us to fix #2.
richvdh added a commit that referenced this issue Mar 28, 2018
@richvdh
Encode with ensure_ascii=True and then fix
8ed84b6 
This turns out to be way quicker. It also allows us to fix #2.
richvdh added a commit that referenced this issue Mar 29, 2018
@richvdh
Encode with ensure_ascii=True and then fix
6eb904b 
This turns out to be way quicker. It also allows us to fix #2.
richvdh added a commit that referenced this issue Mar 29, 2018
@richvdh
Encode with ensure_ascii=True and then fix (#9)
28d01a0 
This turns out to be way quicker. It also allows us to fix #2.
richvdh added a commit that referenced this issue Jun 4, 2018
@richvdh
Encode with ensure_ascii=True and then fix
0fc21ca 
This turns out to be way quicker. It also allows us to fix #2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Encode with ensure_ascii=True and then fix matrix-org/python-canonicaljson
1 participant
@richvdh