Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly package the canonicaljson module #52
Properly package the canonicaljson module #52
Changes from all commits
2d2710b
1e7d67c
c85a01e
60b07c8
e05f3cb
1a367da
339f8d6
e7af4ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These both seem like good things to include in the sdist. Are they included automatically now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per #synapse-dev, it looks like
python -m build
always includes all files from the repository by default when run on my machine, not sure why.According to https://packaging.python.org/en/latest/guides/using-manifest-in/,
pyproject.toml
is automatically included now. I've also added the license file tolicense_file
insetup.cfg
since it seems like that will always cause it to be included.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now replaced the content of
MANIFEST.in
with the suggestion fromcheck-manifest
. The only exception to this is that I've added aprune .github
to remove GitHub codeowner and workflow files, which felt to me like they shouldn't live in the sdist.This file was deleted.