Add support for rejecting sms reqs to countries #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reject requests to send SMS to countries based on rules in the config file element-hq/element-web#3542
ara4n
reviewed
Apr 25, 2017
sydent/validators/msisdnvalidator.py
Outdated
| action = self.sydent.cfg.get('sms', opt) | ||
|
|
||
| if action not in ['allow', 'reject']: | ||
| raise Exception("Invalid SMS rule action: %s, expecting 'allow' or 'deny'" % action) |
|
lgtm other than comedy thinko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject requests to send SMS to countries based on rules in the
config file
element-hq/element-web#3542
Requires matrix-org/synapse#2147 (but can be merged without)