This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
RoomAccessRules cleanup #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
approved these changes
Sep 10, 2020
| ACCESS_RULE_DIRECT = "direct" | ||
|
|
||
|
|
||
| class AccessRules: |
There was a problem hiding this comment.
for future reference, https://docs.python.org/3/library/enum.html might be a useful thing for this sort of construction (saves maintaining a separate VALID_ACCESS_RULES)
There was a problem hiding this comment.
@richvdh I actually spent about an hour trying to make this work with Enum and failed, eventually reverting back to VALID_ACCESS_RULES. Reason being that while one can say isinstance(rule, AccessRule), rule must be an instance of AccessRule. Since we're JSON serialising and deserialising stuff in the tests and the code here, that would've meant having to cast strings to AccessRule all over the place.
Thus VALID_ACCESS_RULES ended up being the less complex option :)
anoadragon453
requested review from
richvdh
and removed request for
richvdh
anoadragon453
added a commit
that referenced
this pull request
Oct 9, 2020
…oa/freeze_rooms * 'dinsic' of github.com:matrix-org/synapse-dinsic: Only assert valid next_link params when provided (#65) Don't push if an user account has expired (#58) Swap method calls in RoomAccessTestCase.test_change_rules (#64) Make all rooms noisy by default (#60) Make AccessRules use the public rooms directory instead of checking a room's join rules on rule change (#63) Override the power levels defaults, enforce mod requirement for invites, admin requirements for unknown state events (#61) RoomAccessRules cleanup (#62) Add a config option for validating 'next_link' parameters against a domain whitelist (#8275)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various cleanups of the DINUM-specific
RoomAccessRulesmodule, including:I want to leave the
asyncing until we do another round of merging Synapsemasterintodinsic, asThirdPartyEventRulesis not async yet on thedinsicbranch.Reviewable commit-by-commit, though the bulk of the cleanup is in the first and last commits.