Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI/PyPA package? #22

Closed
lullis opened this issue Jun 10, 2019 · 6 comments · Fixed by #70
Closed

PyPI/PyPA package? #22

lullis opened this issue Jun 10, 2019 · 6 comments · Fixed by #70

Comments

@lullis
Copy link

lullis commented Jun 10, 2019

It would be great to have this application available directly on PyPI servers. Any reason it hasn't been done yet?

@HarHarLinks
Copy link

you can install from VCS easily using pip:
pip install git+https://github.com/matrix-org/synapse-s3-storage-provider

@lullis
Copy link
Author

lullis commented Apr 13, 2020

Yes, I know that is possible. However, it is not an answer to the question.

The reason that a "plain pip" package is desirable. I would like to automate the installation of a series of matirix servers. Depending on git forces me to install another dependency on the machine, and not having an actual release prevents me from pinning the version of this package.

synapse itself already has a pip package. Is there any reason that this module can not also have one as well? Perhaps I could help.

@clokep
Copy link
Member

clokep commented Apr 13, 2020

I suspect there isn't any particular reason -- just that doing official releases requires a bunch of additional procedure. If this is already installable via pip that's good, we might need to just setup some changelogs and such.

@richvdh
Copy link
Member

richvdh commented Apr 16, 2020

we expect to be doing a bit of work on this project in the near future; we'll try to incorporate this as part of it.

@ShadowJonathan
Copy link
Contributor

I recently came across this problem when making a synapse container with this plugin inside of it (#14), I tried to use this Dockerfile configuration first:

FROM matrixdotorg/synapse:latest

RUN git clone https://github.com/matrix-org/synapse-s3-storage-provider.git && \
        cd /synapse-s3-storage-provider && \
        pip install .

I compounded that down to

...
RUN pip install git+https://github.com/matrix-org/synapse-s3-storage-provider

But in both cases it failed, because git wasn't installed.

apk wasn't present, and apt wasnt up-to-date (i couldnt do apt install git -y right off the bat)

This is what i settled with:

...
RUN apt update && apt install git -y && \
      pip install git+https://github.com/matrix-org/synapse-s3-storage-provider

Publishing just a package would clutter less, like this.

@inaniyants
Copy link

inaniyants commented May 24, 2021

Hi! This package was published to pip registry on May 18, 2021.
Here are details:
#14 (comment)

But in order to close this issue, publication to pip registry should be automated and some versioning would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants