Rate limit early

matrix-org · May 2, 2019 · 176f31c · 176f31c
1 parent d6118c5
commit 176f31c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/synapse/handlers/room_member.py b/synapse/handlers/room_member.py
@@ -710,8 +710,9 @@ def do_3pid_invite(
                     Codes.FORBIDDEN,
                 )
 
-        # Check whether we'll be ratelimited
-        yield self.base_handler.ratelimit(requester, update=False)
+        # We need to rate limit *before* we send out any 3PID invites, so we
+        # can't just rely on the standard ratelimiting of events.
+        yield self.base_handler.ratelimit(requester)
 
         invitee = yield self._lookup_3pid(
             id_server, medium, address