Remove the cap on federation retry interval. (#6026)

Essentially the intention here is to end up blacklisting servers which never respond to federation requests. Fixes #5113.
matrix-org · Sep 12, 2019 · 3d882a7 · 3d882a7
1 parent 0388bea
commit 3d882a7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/6026.feature b/changelog.d/6026.feature
@@ -0,0 +1 @@
+Stop sending federation transactions to servers which have been down for a long time.
diff --git a/synapse/util/retryutils.py b/synapse/util/retryutils.py
@@ -28,8 +28,8 @@
 # how much we multiply the backoff by after each subsequent fail
 RETRY_MULTIPLIER = 5
 
-# a cap on the backoff
-MAX_RETRY_INTERVAL = 24 * 60 * 60 * 1000
+# a cap on the backoff. (Essentially none)
+MAX_RETRY_INTERVAL = 2 ** 63
 
 
 class NotRetryingDestination(Exception):
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Stop sending federation transactions to servers which have been down for a long time.