Ensure that UI auth stages are idempotent.

matrix-org · Apr 17, 2020 · 4cfc49c · 4cfc49c
1 parent bb311c0
commit 4cfc49c
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/synapse/storage/data_stores/main/ui_auth.py b/synapse/storage/data_stores/main/ui_auth.py
@@ -94,13 +94,10 @@ async def mark_stage_complete(
             stage_type: The completed stage type.
             identity: The identity authenticated by the stage.
         """
-        await self.db.simple_insert(
+        await self.db.simple_upsert(
             table="ui_auth_sessions_credentials",
-            values={
-                "session_id": session_id,
-                "stage_type": stage_type,
-                "identity": json.dumps(identity),
-            },
+            keyvalues={"session_id": session_id, "stage_type": stage_type},
+            values={"identity": json.dumps(identity)},
             desc="mark_stage_complete",
         )