remove urllib3 pin (#5230)

requests 2.22.0 as been released supporting urllib3 1.25.2 Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>
matrix-org · May 22, 2019 · 62388a1 · 62388a1
1 parent ae5521b
commit 62388a1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/changelog.d/5230.misc b/changelog.d/5230.misc
@@ -0,0 +1 @@
+Remove urllib3 pin as requests 2.22.0 has been released supporting urllib3 1.25.2.
diff --git a/synapse/python_dependencies.py b/synapse/python_dependencies.py
@@ -74,14 +74,6 @@
     "attrs>=17.4.0",
 
     "netaddr>=0.7.18",
-
-    # requests is a transitive dep of treq, and urlib3 is a transitive dep
-    # of requests, as well as of sentry-sdk.
-    #
-    # As of requests 2.21, requests does not yet support urllib3 1.25.
-    # (If we do not pin it here, pip will give us the latest urllib3
-    # due to the dep via sentry-sdk.)
-    "urllib3<1.25",
 ]
 
 CONDITIONAL_REQUIREMENTS = {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Remove urllib3 pin as requests 2.22.0 has been released supporting urllib3 1.25.2.