Fix using MSC2716 batch sending with event persistence workers (#11220)

Signed-off-by: Tulir Asokan <tulir@beeper.com>
matrix-org · Nov 29, 2021 · 7b4e228 · 7b4e228
1 parent dc0a3cd
commit 7b4e228
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/changelog.d/11220.bugfix b/changelog.d/11220.bugfix
@@ -0,0 +1 @@
+Fix using MSC2716 batch sending in combination with event persistence workers. Contributed by @tulir at Beeper.
diff --git a/synapse/app/generic_worker.py b/synapse/app/generic_worker.py
@@ -113,6 +113,7 @@
 )
 from synapse.storage.databases.main.presence import PresenceStore
 from synapse.storage.databases.main.room import RoomWorkerStore
+from synapse.storage.databases.main.room_batch import RoomBatchStore
 from synapse.storage.databases.main.search import SearchStore
 from synapse.storage.databases.main.session import SessionStore
 from synapse.storage.databases.main.stats import StatsStore
@@ -240,6 +241,7 @@ class GenericWorkerSlavedStore(
     SlavedEventStore,
     SlavedKeyStore,
     RoomWorkerStore,
+    RoomBatchStore,
     DirectoryStore,
     SlavedApplicationServiceStore,
     SlavedRegistrationStore,

diff --git a/synapse/events/snapshot.py b/synapse/events/snapshot.py
@@ -322,6 +322,11 @@ async def _fill_out_state(self) -> None:
         attributes by loading from the database.
         """
         if self.state_group is None:
+            # No state group means the event is an outlier. Usually the state_ids dicts are also
+            # pre-set to empty dicts, but they get reset when the context is serialized, so set
+            # them to empty dicts again here.
+            self._current_state_ids = {}
+            self._prev_state_ids = {}
             return
 
         current_state_ids = await self._storage.state.get_state_ids_for_group(
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix using MSC2716 batch sending in combination with event persistence workers. Contributed by @tulir at Beeper.