Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Strip trailing / from server_url in register_new_matrix_user (#8823)
Browse files Browse the repository at this point in the history
When server URL provided to register_new_matrix_user includes path
component (e.g. "http://localhost:8008/"), the command fails with
"ERROR! Received 400 Bad Request". Stripping trailing slash from the
server_url command argument makes sure combined endpoint URL remains
valid.

Signed-off-by: Dmitry Borodaenko angdraug@debian.org
  • Loading branch information
angdraug authored Nov 26, 2020
1 parent 14f81a6 commit 7c43447
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.d/8823.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix `register_new_matrix_user` failing with "Bad Request" when trailing slash is included in server URL. Contributed by @angdraug.
2 changes: 1 addition & 1 deletion synapse/_scripts/register_new_matrix_user.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def request_registration(
exit=sys.exit,
):

url = "%s/_synapse/admin/v1/register" % (server_location,)
url = "%s/_synapse/admin/v1/register" % (server_location.rstrip("/"),)

# Get the nonce
r = requests.get(url, verify=False)
Expand Down

0 comments on commit 7c43447

Please sign in to comment.