Merge pull request #5389 from matrix-org/erikj/renew_attestations_on_…

…master
matrix-org · Feb 10, 2020 · 9a26972 · 9a26972
2 parents 8396268 + 414d2ca
commit 9a26972
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/changelog.d/5389.bugfix b/changelog.d/5389.bugfix
@@ -0,0 +1 @@
+Fix exceptions in federation reader worker caused by attempting to renew attestations, which should only happen on master worker.
diff --git a/synapse/groups/attestations.py b/synapse/groups/attestations.py
@@ -132,9 +132,10 @@ def __init__(self, hs):
         self.is_mine_id = hs.is_mine_id
         self.attestations = hs.get_groups_attestation_signing()
 
-        self._renew_attestations_loop = self.clock.looping_call(
-            self._start_renew_attestations, 30 * 60 * 1000,
-        )
+        if not hs.config.worker_app:
+            self._renew_attestations_loop = self.clock.looping_call(
+                self._start_renew_attestations, 30 * 60 * 1000,
+            )
 
     @defer.inlineCallbacks
     def on_renew_attestation(self, group_id, user_id, content):