Apply federation check for /publicRooms with filter list (#7367)

matrix-org · Apr 30, 2020 · 9d8ecc9 · 9d8ecc9
1 parent 37f6823
commit 9d8ecc9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/changelog.d/7367.bugfix b/changelog.d/7367.bugfix
@@ -0,0 +1 @@
+Prevent non-federating rooms from appearing in responses to federated `POST /publicRoom` requests when a filter was included.
diff --git a/synapse/handlers/room_list.py b/synapse/handlers/room_list.py
@@ -90,7 +90,11 @@ def get_local_public_room_list(
             logger.info("Bypassing cache as search request.")
 
             return self._get_public_room_list(
-                limit, since_token, search_filter, network_tuple=network_tuple
+                limit,
+                since_token,
+                search_filter,
+                network_tuple=network_tuple,
+                from_federation=from_federation,
             )
 
         key = (limit, since_token, network_tuple)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Prevent non-federating rooms from appearing in responses to federated `POST /publicRoom` requests when a filter was included.