Fix bug in replication where response is cached (#15024)

matrix-org · Feb 8, 2023 · c78c67c · c78c67c
1 parent d83178a
commit c78c67c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/changelog.d/15024.bugfix b/changelog.d/15024.bugfix
@@ -0,0 +1 @@
+Fix bug where retried replication requests would return a failure. Introduced in v1.76.0.
diff --git a/synapse/replication/http/_base.py b/synapse/replication/http/_base.py
@@ -426,6 +426,8 @@ async def _check_auth_and_handle(
             code, response = await self.response_cache.wrap(
                 txn_id, self._handle_request, request, content, **kwargs
             )
+            # Take a copy so we don't mutate things in the cache.
+            response = dict(response)
         else:
             # The `@cancellable` decorator may be applied to `_handle_request`. But we
             # told `HttpServer.register_paths` that our handler is `_check_auth_and_handle`,